Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move static constants on path following from FlxObject to FlxPath #218

Merged
merged 2 commits into from
Nov 9, 2014

Conversation

Dovyski
Copy link
Member

@Dovyski Dovyski commented Aug 17, 2014

The old PATH_ prefix no longer makes sense, so it was dropped, e.g. FlxObject.PATH_FORWARD is now FlxPath.FORWARD.

Fix: #112

…FlxObject to FlxPath

The old "PATH_" prefix no longer makes sense, so it was dropped, e.g. FlxObject.PATH_FORWARD is now FlxPath.FORWARD.
@IQAndreas
Copy link
Member

Great!

I realize they are only static constants, but do you want to add redirects from the old location to the new one just to assist people learning the new locations? Like this: https://github.com/FlixelCommunity/flixel/blob/dev/src/flixel/util/FlxU.as#L397

Though, the code needs to be modified slightly for constants (it's actually a getter that looks like a constant, I love how you can do that in AS3):

/**
* Path behavior controls: move from the start of the path to the end then stop.
* 
* @deprecated This property is deprecated. Use <code>FlxPath.FORWARD()</code> instead.
*/
static public function get PATH_FORWARD():uint
{
    FlxG.warnDeprecated('FlxObject.PATH_FORWARD', 'FlxPath.FORWARD');
    return FlxPath.FORWARD;
}

@Dovyski
Copy link
Member Author

Dovyski commented Aug 18, 2014

Sure! I forgot about that. As soon as I have some time I will add them.

@Dovyski
Copy link
Member Author

Dovyski commented Oct 17, 2014

I've added the deprecate warnings and tested the code. It looks good to me. It's good to merge.

Dovyski added a commit that referenced this pull request Nov 9, 2014
Move static constants on path following from FlxObject to FlxPath.
@Dovyski Dovyski merged commit cfdd9d8 into FlixelCommunity:dev Nov 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants